lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Oct 2022 19:15:33 +0000 From: Sean Christopherson <seanjc@...gle.com> To: Vitaly Kuznetsov <vkuznets@...hat.com> Cc: kvm@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>, Wanpeng Li <wanpengli@...cent.com>, Jim Mattson <jmattson@...gle.com>, Maxim Levitsky <mlevitsk@...hat.com>, Michael Kelley <mikelley@...rosoft.com>, linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v4 2/6] KVM: x86: Introduce CPUID_8000_0007_EDX 'scattered' leaf On Thu, Sep 22, 2022, Vitaly Kuznetsov wrote: > diff --git a/arch/x86/kvm/reverse_cpuid.h b/arch/x86/kvm/reverse_cpuid.h > index a19d473d0184..a5514c89dc29 100644 > --- a/arch/x86/kvm/reverse_cpuid.h > +++ b/arch/x86/kvm/reverse_cpuid.h > @@ -12,7 +12,8 @@ > * "bug" caps, but KVM doesn't use those. > */ > enum kvm_only_cpuid_leafs { > - CPUID_12_EAX = NCAPINTS, > + CPUID_12_EAX = NCAPINTS, > + CPUID_8000_0007_EDX = NCAPINTS + 1, No need to explicitly initialize the new leaf, only the first enum entry needs explicit initialization to NCAPINTS, i.e. let all other entries automatically increment. The order doesn't matter, so not caring about the exact value will avoid bugs due to mismerge and/or bad copy+paste.
Powered by blists - more mailing lists