linux-kernel - Re: [PATCH] selftests/ftrace: fix dynamic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADyE4xEkQo+AEEbRwcsQDcU_tWAH_m-XE6iZYRnw97Hz9ZHxYA@mail.gmail.com>
Date:   Wed, 12 Oct 2022 12:21:11 +0100
From:   Masami Hiramatsu <masami.hiramatsu@...il.com>
To:     Sven Schnelle <svens@...ux.ibm.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>, Shuah Khan <shuah@...nel.org>,
        "Masami Hiramatsu (Google)" <mhiramat@...nel.org>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/ftrace: fix dynamic_events dependency check

Hi Sven,

2022年10月10日(月) 8:42 Sven Schnelle <svens@...ux.ibm.com>:
>
> commit 95c104c378dc ("tracing: Auto generate event name when creating a
> group of events") changed the syntax in the ftrace README file which is
> used by the selftests to check what features are support. Adjust the
> string to make test_duplicates.tc and trigger-synthetic-eprobe.tc work
> again.
>
> Fixes: 95c104c378dc ("tracing: Auto generate event name when creating a group of events")
> Signed-off-by: Sven Schnelle <svens@...ux.ibm.com>

Thanks for fixing it!

Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

> ---
>  .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +-
>  .../test.d/trigger/inter-event/trigger-synthetic-eprobe.tc      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> index db522577ff78..d3a79da215c8 100644
> --- a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> +++ b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> @@ -1,7 +1,7 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0
>  # description: Generic dynamic event - check if duplicate events are caught
> -# requires: dynamic_events "e[:[<group>/]<event>] <attached-group>.<attached-event> [<args>]":README
> +# requires: dynamic_events "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README
>
>  echo 0 > events/enable
>
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc
> index 914fe2e5d030..6461c375694f 100644
> --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc
> @@ -1,7 +1,7 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0
>  # description: event trigger - test inter-event histogram trigger eprobe on synthetic event
> -# requires: dynamic_events synthetic_events events/syscalls/sys_enter_openat/hist "e[:[<group>/]<event>] <attached-group>.<attached-event> [<args>]":README
> +# requires: dynamic_events synthetic_events events/syscalls/sys_enter_openat/hist "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args>]":README
>
>  echo 0 > events/enable
>
> --
> 2.34.1
>


-- 
Masami Hiramatsu
mailto:masami.hiramatsu@...il.com