[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2eaae603-9726-290e-7c9d-67b89256140c@linaro.org>
Date: Wed, 12 Oct 2022 09:38:26 -0400
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Bryan Brattlof <bb@...com>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Amit Kucheria <amitk@...nel.org>,
Zhang Rui <rui.zhang@...el.com>, Nishanth Menon <nm@...com>,
Vignesh Raghavendra <vigneshr@...com>,
Tero Kristo <kristo@...nel.org>, Keerthy <j-keerthy@...com>,
Linux Thermal <linux-pm@...r.kernel.org>,
Linux Device Tree <devicetree@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 06/11] dt-bindings: thermal: k3-j72xx: conditionally
require efuse reg range
On 11/10/2022 19:17, Bryan Brattlof wrote:
> Only some of TI's J721E SoCs will need a eFuse register range mapped to
> determine if they're affected by TI's i2128 erratum. All other SoC will
> not need this eFuse range to be mapped to function properly
>
> Update the bindings for the k3_j72xx_bandgap thermal driver so other
> devices will only need to define two register ranges
>
> Signed-off-by: Bryan Brattlof <bb@...com>
> ---
> .../bindings/thermal/ti,j72xx-thermal.yaml | 34 +++++++++++++------
> 1 file changed, 24 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> index 0b6a6fa07a532..387628ab35959 100644
> --- a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> @@ -33,16 +33,6 @@ properties:
> - ti,j721e-vtm
> - ti,j7200-vtm
>
> - reg:
No, keep entire part here.
with minItems:2
> - items:
> - - description: VTM cfg1 register space
> - - description: VTM cfg2 register space
> - - description: |
> - A software trimming method must be applied to some Jacinto
> - devices to function properly. This eFuse region provides
> - the information needed for these SoCs to report
> - temperatures accurately.
> -
> power-domains:
> description: |
> Should contain the phandle to a power management (PM) domain
> @@ -52,6 +42,30 @@ properties:
> "#thermal-sensor-cells":
> const: 1
>
> +if:
Put it under allOf.
> + properties:
> + compatible:
> + contains:
> + enum:
> + - ti,j721e-vtm
> +then:
> + properties:
> + reg:
> + items:
> + - description: VTM cfg1 register space
> + - description: VTM cfg2 register space
> + - description: |
> + A software trimming method must be applied to some Jacinto
> + devices to function properly. This eFuse region provides
> + the information needed for these SoCs to report
> + temperatures accurately.
Instead:
minItems: 3
> +else:
> + properties:
> + reg:
> + items:
> + - description: VTM cfg1 register space
> + - description: VTM cfg2 register space
Instead:
maxItems: 2
> +
> required:
> - compatible
> - reg
Best regards,
Krzysztof
Powered by blists - more mailing lists