linux-kernel - Re: [PATCH 05/11] dt-bindings: thermal: k3-j72xx: elaborate on binding descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06249fe9-97eb-1ab8-5e35-00b3c613d3a7@linaro.org>
Date:   Wed, 12 Oct 2022 09:36:04 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Bryan Brattlof <bb@...com>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>, Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>, Keerthy <j-keerthy@...com>,
        Linux Thermal <linux-pm@...r.kernel.org>,
        Linux Device Tree <devicetree@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 05/11] dt-bindings: thermal: k3-j72xx: elaborate on
 binding descriptions

On 11/10/2022 19:17, Bryan Brattlof wrote:
> Elaborate on the function of this device node as well as some of the
> properties that this node uses.
> 
> Signed-off-by: Bryan Brattlof <bb@...com>
> ---
>  .../bindings/thermal/ti,j72xx-thermal.yaml    | 27 ++++++++++++++++++-
>  1 file changed, 26 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> index c74f124ebfc00..0b6a6fa07a532 100644
> --- a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml
> @@ -9,6 +9,24 @@ title: Texas Instruments J72XX VTM (DTS) binding
>  maintainers:
>    - Keerthy <j-keerthy@...com>
>  
> +description: |
> +  The TI K3 family of SoCs typically have a Voltage & Thermal
> +  Management (VTM) device to control up to 8 temperature diode
> +  sensors to measure silicon junction temperatures from different
> +  hotspots of the chip as well as provide temperature, interrupt
> +  and alerting information.
> +
> +  The VTM device will periodically enable these temperature sensors
> +  to make a temperature measurement and store the reported data
> +  allowing the sensors to stay in a reset state when not in use
> +  to maximize the sensor's life.
> +
> +  This VTM driver will then use the following polynomial equation to

"VTM driver" is some physical/electronic element called driver? Or Linux
driver? If the latter, drop it and just describe the equation.

> +  calculate the temperature from the value stored in the VTM device.
> +
> +  Temp = (-9.2627e-12) * x^4 + (6.0373e-08) * x^3 + \
> +         (-1.7058e-04) * x^2 + (3.2512e-01) * x   + (-4.9003e+01)
> +
>  properties:
>    compatible:
>      enum:
> @@ -19,9 +37,16 @@ properties:
>      items:
>        - description: VTM cfg1 register space
>        - description: VTM cfg2 register space
> -      - description: VTM efuse register space
> +      - description: |
> +          A software trimming method must be applied to some Jacinto
> +          devices to function properly. This eFuse region provides
> +          the information needed for these SoCs to report
> +          temperatures accurately.
>  
>    power-domains:
> +    description: |
> +      Should contain the phandle to a power management (PM) domain
> +      node and the device-id of this device.

This is quite generic - why adding it?

>      maxItems: 1
>  
>    "#thermal-sensor-cells":

Best regards,
Krzysztof