linux-kernel - Re: [PATCH v1 1/5] soc: hpe: add support for HPE GXP Programmable Register Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202210120841.3TZZADy3-lkp@intel.com>
Date:   Wed, 12 Oct 2022 08:28:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     nick.hawkins@....com, verdun@....com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux@...linux.org.uk,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Cc:     kbuild-all@...ts.01.org
Subject: Re: [PATCH v1 1/5] soc: hpe: add support for HPE GXP Programmable
 Register Driver

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.0 next-20221011]
[cannot apply to robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/nick-hawkins-hpe-com/Add-PLREG-and-SPI-Driver-GXP-Support/20221012-025828
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 041bc24d867a2a577a06534d6d25e500b24a01ef
config: arm-defconfig
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/d4029a90cf878fd77b6fc62501099aa6dac87f5c
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review nick-hawkins-hpe-com/Add-PLREG-and-SPI-Driver-GXP-Support/20221012-025828
        git checkout d4029a90cf878fd77b6fc62501099aa6dac87f5c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/soc/hpe/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/soc/hpe/gxp-plreg.c:189:5: warning: no previous prototype for 'gxp_plreg_get_fan_inst' [-Wmissing-prototypes]
     189 | int gxp_plreg_get_fan_inst(int fan)
         |     ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/soc/hpe/gxp-plreg.c:209:5: warning: no previous prototype for 'gxp_plreg_get_fan_fail' [-Wmissing-prototypes]
     209 | int gxp_plreg_get_fan_fail(int fan)
         |     ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/soc/hpe/gxp-plreg.c:229:5: warning: no previous prototype for 'gxp_plreg_get_fan_id' [-Wmissing-prototypes]
     229 | int gxp_plreg_get_fan_id(int fan)
         |     ^~~~~~~~~~~~~~~~~~~~
>> drivers/soc/hpe/gxp-plreg.c:249:6: warning: no previous prototype for 'gxp_plreg_do_virt_pwr_btn_latch' [-Wmissing-prototypes]
     249 | void gxp_plreg_do_virt_pwr_btn_latch(void)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/gxp_plreg_get_fan_inst +189 drivers/soc/hpe/gxp-plreg.c

   188	
 > 189	int gxp_plreg_get_fan_inst(int fan)
   190	{
   191		struct gxp_plreg_drvdata *drvdata = &client_data;
   192		u32 trans_offset;
   193		u32 trans_shift;
   194		u32 val;
   195	
   196		address_translation(drvdata->fan[fan].inst,
   197				    &trans_offset,
   198				    &trans_shift);
   199	
   200		regmap_read(drvdata->plreg_map, trans_offset, &val);
   201		val = (val >> trans_shift) & drvdata->fan[fan].bit;
   202		if (val == drvdata->fan[fan].bit)
   203			return 1;
   204		else
   205			return 0;
   206	}
   207	EXPORT_SYMBOL(gxp_plreg_get_fan_inst);
   208	
 > 209	int gxp_plreg_get_fan_fail(int fan)
   210	{
   211		struct gxp_plreg_drvdata *drvdata = &client_data;
   212		u32 trans_offset;
   213		u32 trans_shift;
   214		u32 val;
   215	
   216		address_translation(drvdata->fan[fan].fail,
   217				    &trans_offset,
   218				    &trans_shift);
   219	
   220		regmap_read(drvdata->plreg_map, trans_offset, &val);
   221		val = (val >> trans_shift) & drvdata->fan[fan].bit;
   222		if (val == drvdata->fan[fan].bit)
   223			return 1;
   224		else
   225			return 0;
   226	}
   227	EXPORT_SYMBOL(gxp_plreg_get_fan_fail);
   228	
 > 229	int gxp_plreg_get_fan_id(int fan)
   230	{
   231		struct gxp_plreg_drvdata *drvdata = &client_data;
   232		u32 trans_offset;
   233		u32 trans_shift;
   234		u32 val;
   235	
   236		address_translation(drvdata->fan[fan].id,
   237				    &trans_offset,
   238				    &trans_shift);
   239	
   240		regmap_read(drvdata->plreg_map, trans_offset, &val);
   241		val = (val >> trans_shift) & drvdata->fan[fan].bit;
   242		if (val == drvdata->fan[fan].bit)
   243			return 1;
   244		else
   245			return 0;
   246	}
   247	EXPORT_SYMBOL(gxp_plreg_get_fan_id);
   248	
 > 249	void gxp_plreg_do_virt_pwr_btn_latch(void)
   250	{
   251		struct gxp_plreg_drvdata *drvdata = &client_data;
   252		u32 trans_offset;
   253		u32 trans_shift;
   254	
   255		address_translation(drvdata->pwrbtn.latch[BYTE],
   256				    &trans_offset,
   257				    &trans_shift);
   258	
   259		regmap_update_bits(drvdata->plreg_map, trans_offset,
   260				   drvdata->pwrbtn.latch[MASK] << trans_shift,
   261				   drvdata->pwrbtn.latch[VALUE] << trans_shift);
   262	}
   263	EXPORT_SYMBOL(gxp_plreg_do_virt_pwr_btn_latch);
   264	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (262493 bytes)