linux-kernel - Re: [PATCH 4.19] scsi: sd: Fix 'sdkp' in sd_first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221013044927.278854-1-kunyu@nfschina.com>
Date:   Thu, 13 Oct 2022 12:49:26 +0800
From:   Li kunyu <kunyu@...china.com>
To:     damien.lemoal@...nsource.wdc.com
Cc:     jejb@...ux.vnet.ibm.com, kunyu@...china.com,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        martin.petersen@...cle.com
Subject: Re: [PATCH 4.19] scsi: sd: Fix 'sdkp' in sd_first_printk


This is defined in the 4.19 kernel:

#define sd_printk(prefix, sdsk, fmt, a...)                              \
        (sdsk)->disk ?                                                  \
              sdev_prefix_printk(prefix, (sdsk)->device,                \
                                 (sdsk)->disk->disk_name, fmt, ##a) :   \
              sdev_printk(prefix, (sdsk)->device, fmt, ##a)

#define sd_first_printk(prefix, sdsk, fmt, a...)                        \
        do {                                                            \
                if ((sdkp)->first_scan)                                 \
                        sd_printk(prefix, sdsk, fmt, ##a);              \
        } while (0)



Most of the sdsk used in the macro definition has only one sdkp.


This is defined in the v6.0-rc7 kernel:

#define sd_printk(prefix, sdsk, fmt, a...)                              \
        (sdsk)->disk ?                                                  \
              sdev_prefix_printk(prefix, (sdsk)->device,                \
                                 (sdsk)->disk->disk_name, fmt, ##a) :   \
              sdev_printk(prefix, (sdsk)->device, fmt, ##a)

#define sd_first_printk(prefix, sdsk, fmt, a...)                        \
        do {                                                            \
                if ((sdsk)->first_scan)                                 \
                        sd_printk(prefix, sdsk, fmt, ##a);              \
        } while (0)

Use sdsk in macro definition.


I did report an error when compiling sd. o in the 4.19 kernel. It was modified to say that no more errors were reported in sdsk. Can I continue the 6.0-rc7 writing method here.