linux-kernel - Re: [PATCH 4.19] scsi: sd: Fix 'sdkp' in sd_first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Oct 2022 12:54:40 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     Li kunyu <kunyu@...china.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4.19] scsi: sd: Fix 'sdkp' in sd_first_printk

On 2022/10/13 11:34, Li kunyu wrote:
> In the sd_first_printk macro, replace the sdkp parameter with the
> defined sdsk parameter to resolve the compilation error.

Which compilation errors ? None that I can see.
Do you mean "to avoid potential compilation errors" ?

> 
> Signed-off-by: Li kunyu <kunyu@...china.com>
> ---
>  drivers/scsi/sd.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h
> index a7d4f50b67d4..e5bdf0a10071 100644
> --- a/drivers/scsi/sd.h
> +++ b/drivers/scsi/sd.h
> @@ -133,7 +133,7 @@ static inline struct scsi_disk *scsi_disk(struct gendisk *disk)
>  
>  #define sd_first_printk(prefix, sdsk, fmt, a...)			\
>  	do {								\
> -		if ((sdkp)->first_scan)					\
> +		if ((sdsk)->first_scan)					\

Instead of changing this one, I would prefer changing sdsk to sdkp in the macro
parameter list. "sdkp" is used everywhere in sd.c. "sdsk" is not used anywhere
so it would be unclear.

>  			sd_printk(prefix, sdsk, fmt, ##a);		\
>  	} while (0)
>  

-- 
Damien Le Moal
Western Digital Research