linux-kernel - Re: [PATCH 7/8] serial: 8250/ingenic: Add support for the JZ4750/JZ4755 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <GSPOJR.M4XZ4D03G60F@crapouillou.net>
Date:   Thu, 13 Oct 2022 10:17:04 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     Siarhei Volkau <lis8215@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>, kernel test robot <lkp@...el.com>,
        kbuild-all@...ts.01.org,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jiri Slaby <jirislaby@...nel.org>, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        dmaengine@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-mips@...r.kernel.org,
        GPIO SUBSYSTEM <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 7/8] serial: 8250/ingenic: Add support for the
 JZ4750/JZ4755 SoCs

Hi,

Le jeu., oct. 13 2022 at 08:46:39 +0200, Arnd Bergmann <arnd@...db.de> 
a écrit :
> On Thu, Oct 13, 2022, at 8:37 AM, Siarhei Volkau wrote:
>>  пн, 10 окт. 2022 г. в 01:29, kernel test robot 
>> <lkp@...el.com>:
>>>  config: ia64-allyesconfig
>>>  config: arm64-randconfig-r035-20221010
>> 
>>>   > 142  #define CGU_REG_CPCCR   ((void *)CKSEG1ADDR(0x10000000))
>> 
>>>  0-DAY CI Kernel Test Service
>> 
>>  I know CKSEG1ADDR is MIPS specific, might be it needed to disable 
>> COMPILE_TEST
>>  on the driver?
>>  Since early syscon isn't mainlined yet I don't see any other way at 
>> the moment.
>> 
>>  Any suggestions on that, folks?
> 
> This looks like some setup that belongs into the bootloader. If you 
> are
> handing over the console from bootloader to kernel, the hardware 
> should
> already be in a working state, with no need to touch it during early
> boot.
> 
> If you are dealing with broken bootloaders that are not under your 
> control,
> having this code in the architecture specific early boot as a fixup
> would be better than putting it into the driver.

Agreed. I am not fond of having a driver poking into an unrelated 
subsystem's memory area.

Just disable the divider in ingenic_fixup_fdt() in 
arch/mips/generic/board-ingenic.c.

Cheers,
-Paul