linux-kernel - Re: [PATCH v2] ACPI: ARM Performance Monitoring Unit Table (APMT) initial support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221014105550.zf7ufboxid3jryrz@bogus>
Date:   Fri, 14 Oct 2022 11:55:50 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Besar Wicaksono <bwicaksono@...dia.com>, lorenzo.pieralisi@....com,
        lenb@...nel.org, catalin.marinas@....com, will@...nel.org,
        guohanjun@...wei.com, linux-tegra@...r.kernel.org,
        treding@...dia.com, jonathanh@...dia.com, vsethi@...dia.com,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] ACPI: ARM Performance Monitoring Unit Table (APMT)
 initial support

On Fri, Sep 30, 2022 at 07:46:08PM +0200, Rafael J. Wysocki wrote:
> On Thu, Sep 29, 2022 at 2:29 AM Besar Wicaksono <bwicaksono@...dia.com> wrote:
> >
> > ARM Performance Monitoring Unit Table describes the properties of PMU
> > support in ARM-based system. The APMT table contains a list of nodes,
> > each represents a PMU in the system that conforms to ARM CoreSight PMU
> > architecture. The properties of each node include information required
> > to access the PMU (e.g. MMIO base address, interrupt number) and also
> > identification. For more detailed information, please refer to the
> > specification below:
> >  * APMT: https://developer.arm.com/documentation/den0117/latest
> >  * ARM Coresight PMU:
> >         https://developer.arm.com/documentation/ihi0091/latest
> >
> > The initial support adds the detection of APMT table and generic
> > infrastructure to create platform devices for ARM CoreSight PMUs.
> > Similar to IORT the root pointer of APMT is preserved during runtime
> > and each PMU platform device is given a pointer to the corresponding
> > APMT node.
> >
> > Signed-off-by: Besar Wicaksono <bwicaksono@...dia.com>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> for the change in bus.c, but as a side note, it would be good to move
> all of the ARM-specific initialization into one place, so it is not
> necessary to touch bus.c every time a new piece of it is added.
>

Agreed, I will look into that and move them all under single acpi_arm_init()
or something.

-- 
Regards,
Sudeep