linux-kernel - Re: [PATCH] scripts: rust_is_available.sh: Provide hints on how to fix missing pieces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mFGoDySLHNyakOnJMDpRVmvCRUAAuiKw1B2KrMhFteCA@mail.gmail.com>
Date:   Fri, 14 Oct 2022 18:21:23 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Olof Johansson <olof@...om.net>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: rust_is_available.sh: Provide hints on how to
 fix missing pieces

On Tue, Oct 4, 2022 at 8:47 PM Olof Johansson <olof@...om.net> wrote:
>
> This might be a bit bikesheddy, but it saves a few roundtrips to the
> documentation when getting the `make LLVM=1 rustavailable` run to pass.

It is faster for someone that already knows how things work, but it
may make newcomers skip the docs and it duplicates the information
there. In addition, for the non-error case, it makes it more verbose
which may not be appreciated. So maybe we should point to the docs
instead? What do you think?

Also, the patch doesn't add instructions for all the cases, so
somebody that may have hit one of the documented ones + not have read
the docs may wonder where to find them the solution or why they are
missing.

Thanks!

Cheers,
Miguel