linux-kernel - Re: [PATCH] usbip: convert sysfs snprintf to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <38bda8e2-0948-ed48-f2e2-670c15c38298@linuxfoundation.org>
Date:   Fri, 14 Oct 2022 10:22:10 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Xuezhi Zhang <zhangxuezhi3@...il.com>, valentina.manea.m@...il.com,
        shuah@...nel.org, gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Xuezhi Zhang <zhangxuezhi1@...lpad.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] usbip: convert sysfs snprintf to sysfs_emit

On 10/14/22 05:06, Xuezhi Zhang wrote:
> From: Xuezhi Zhang <zhangxuezhi1@...lpad.com>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst
> and show() should only use sysfs_emit() or sysfs_emit_at()
> when formatting the value to be returned to user space.
> 
> Signed-off-by: Xuezhi Zhang <zhangxuezhi1@...lpad.com>
> ---

Looks good to me.

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

Greg, Please pick this up.

thanks,
-- Shuah