lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 15 Oct 2022 07:30:36 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: ira.weiny@...el.com Cc: Dan Williams <dan.j.williams@...el.com>, Alison Schofield <alison.schofield@...el.com>, Vishal Verma <vishal.l.verma@...el.com>, Ben Widawsky <bwidawsk@...nel.org>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, Davidlohr Bueso <dave@...olabs.net>, linux-kernel@...r.kernel.org, linux-cxl@...r.kernel.org Subject: Re: [RFC V2 PATCH 05/11] cxl/mem: Trace General Media Event Record On Mon, 10 Oct 2022 15:41:25 -0700 ira.weiny@...el.com wrote: > +static void cxl_trace_event_record(const char *dev_name, > + enum cxl_event_log_type type, > + struct cxl_get_event_payload *payload) > +{ > + uuid_t *id = &payload->record.hdr.id; > + Perhaps you want to add here: if (!trace_cxl_general_media_enabled() && !trace_clx_generic_event_enabled()) return; This way the below logic is only executed if either event is enabled. The above uses static_branches, so if the architecture supports them, they are not compare and branch, but jumps and/or nops. -- Steve > + if (uuid_equal(id, &gen_media_event_uuid)) { > + struct cxl_event_gen_media *rec = > + (struct cxl_event_gen_media *)&payload->record; > + > + trace_general_media(dev_name, type, rec); > + return; > + } > + > + /* For unknown record types print just the header */ > + trace_generic_event(dev_name, type, &payload->record); > +}
Powered by blists - more mailing lists