lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 15 Oct 2022 09:32:45 +0800 From: Miaohe Lin <linmiaohe@...wei.com> To: Mike Kravetz <mike.kravetz@...cle.com>, <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org> CC: Muchun Song <songmuchun@...edance.com>, David Hildenbrand <david@...hat.com>, Sven Schnelle <svens@...ux.ibm.com>, Michal Hocko <mhocko@...e.com>, Peter Xu <peterx@...hat.com>, Naoya Horiguchi <naoya.horiguchi@...ux.dev>, "Aneesh Kumar K . V" <aneesh.kumar@...ux.vnet.ibm.com>, Andrea Arcangeli <aarcange@...hat.com>, "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>, Davidlohr Bueso <dave@...olabs.net>, Prakash Sangappa <prakash.sangappa@...cle.com>, James Houghton <jthoughton@...gle.com>, Mina Almasry <almasrymina@...gle.com>, Pasha Tatashin <pasha.tatashin@...een.com>, Axel Rasmussen <axelrasmussen@...gle.com>, Ray Fucillo <Ray.Fucillo@...ersystems.com>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [PATCH 2/3] hugetlb: take hugetlb vma_lock when clearing vma_lock->vma pointer On 2022/10/6 11:30, Mike Kravetz wrote: > To address build issues: > > >>>From b6d359f77d32c7734fe4f00806a0ed1e99925534 Mon Sep 17 00:00:00 2001 > From: Mike Kravetz <mike.kravetz@...cle.com> > Date: Wed, 5 Oct 2022 20:26:19 -0700 > Subject: [PATCH 2/3] hugetlb: take hugetlb vma_lock when clearing > vma_lock->vma pointer > > hugetlb file truncation/hole punch code may need to back out and take > locks in order in the routine hugetlb_unmap_file_folio(). This code > could race with vma freeing as pointed out in [1] and result in > accessing a stale vma pointer. To address this, take the vma_lock when > clearing the vma_lock->vma pointer. > > [1] https://lore.kernel.org/linux-mm/01f10195-7088-4462-6def-909549c75ef4@huawei.com/ > > Fixes: "hugetlb: use new vma_lock for pmd sharing synchronization" > Signed-off-by: Mike Kravetz <mike.kravetz@...cle.com> This patch looks good to me. Thanks. Reviewed-by: Miaohe Lin <linmiaohe@...wei.com> Thanks, Miaohe Lin
Powered by blists - more mailing lists