lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 15 Oct 2022 09:40:18 +0800
From:   Miaohe Lin <>
To:     Mike Kravetz <>, <>,
CC:     Muchun Song <>,
        David Hildenbrand <>,
        Sven Schnelle <>,
        Michal Hocko <>, Peter Xu <>,
        Naoya Horiguchi <>,
        "Aneesh Kumar K . V" <>,
        Andrea Arcangeli <>,
        "Kirill A . Shutemov" <>,
        Davidlohr Bueso <>,
        Prakash Sangappa <>,
        James Houghton <>,
        Mina Almasry <>,
        Pasha Tatashin <>,
        Axel Rasmussen <>,
        Ray Fucillo <>,
        Andrew Morton <>
Subject: Re: [PATCH 3/3] hugetlb: allocate vma lock for all sharable vmas

On 2022/10/5 9:17, Mike Kravetz wrote:
> The hugetlb vma lock was originally designed to synchronize pmd sharing.
> As such, it was only necessary to allocate the lock for vmas that were
> capable of pmd sharing.  Later in the development cycle, it was discovered
> that it could also be used to simplify fault/truncation races as described
> in [1].  However, a subsequent change to allocate the lock for all vmas
> that use the page cache was never made.  A fault/truncation race could
> leave pages in a file past i_size until the file is removed.
> Remove the previous restriction and allocate lock for all VM_MAYSHARE
> vmas.  Warn in the unlikely event of allocation failure.
> Fixes: "hugetlb: clean up code checking for fault/truncation races"
> Signed-off-by: Mike Kravetz <>

I believe this is a feasible solution. Thanks.

Reviewed-by: Miaohe Lin <>

Miaohe Lin

Powered by blists - more mailing lists