linux-kernel - Re: [PATCH v3 11/14] iio: ad7606: simplify using devm_regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221016172457.6637c888@jic23-huawei>
Date:   Sun, 16 Oct 2022 17:24:57 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Matti Vaittinen <mazziesaccount@...il.com>
Cc:     "Sa, Nuno" <Nuno.Sa@...log.com>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 11/14] iio: ad7606: simplify using
 devm_regulator_get_enable()

On Sun, 16 Oct 2022 17:15:29 +0100
Jonathan Cameron <jic23@...nel.org> wrote:

> On Tue, 30 Aug 2022 15:54:07 +0300
> Matti Vaittinen <mazziesaccount@...il.com> wrote:
> 
> > Thanks for the review(s) Nuno!
> > 
> > On 8/30/22 14:46, Sa, Nuno wrote:  
> > >> From: Matti Vaittinen <mazziesaccount@...il.com>
> > >> Sent: Friday, August 19, 2022 9:20 PM
> > >> To: Matti Vaittinen <mazziesaccount@...il.com>; Matti Vaittinen
> > >> <matti.vaittinen@...rohmeurope.com>
> > >> Cc: Lars-Peter Clausen <lars@...afoo.de>; Hennerich, Michael
> > >> <Michael.Hennerich@...log.com>; Jonathan Cameron
> > >> <jic23@...nel.org>; linux-iio@...r.kernel.org; linux-
> > >> kernel@...r.kernel.org
> > >> Subject: [PATCH v3 11/14] iio: ad7606: simplify using
> > >> devm_regulator_get_enable()
> > >>
> > >> [External]
> > >>
> > >> Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(),
> > >> add_action_or_reset(regulator_disable)' and use the
> > >> devm_regulator_get_enable() and drop the pointer to the regulator.
> > >> This simplifies code and makes it less tempting to add manual control
> > >> for the regulator which is also controlled by devm.
> > >>
> > >> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
> > >>
> > >> ---    
> > > 
> > > The commit message could state that while doing the change, dev_err_probe()
> > > was also introduced. Bah, anyways:
> > > 
> > > Acked-by: Nuno Sá <nuno.sa@...log.com>    
> > 
> > Good point. I have few other changes to the series pending - and I 
> > probably need to rebase/respin when -rc1 is out (and dependency patches 
> > are merged from Mark's tree) => I may as well alter the commit message.
> >   
> I tweaked it and applied.
> 
> Not I'm grabbing these early because I forgot you'd sent them and
> found myself writing the same patches.  Memory of a goldfish :)

Tweaked a little more - you missed that the struct in the header had
kernel-doc for the struct regulator *.  Dropped that.

> 
> Jonathan
> 
> > Yours,
> > 	-- Matti
> >   
>