linux-kernel - Re: [PATCH v3 13/14] iio: max1363: simplify using devm_regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 16 Oct 2022 17:37:23 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     "Sa, Nuno" <Nuno.Sa@...log.com>
Cc:     Matti Vaittinen <mazziesaccount@...il.com>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Alexandru Ardelean <aardelean@...iqon.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 13/14] iio: max1363: simplify using
 devm_regulator_get_enable()

On Sun, 16 Oct 2022 17:18:38 +0100
Jonathan Cameron <jic23@...nel.org> wrote:

> On Tue, 30 Aug 2022 11:50:05 +0000
> "Sa, Nuno" <Nuno.Sa@...log.com> wrote:
> 
> > > -----Original Message-----
> > > From: Matti Vaittinen <mazziesaccount@...il.com>
> > > Sent: Friday, August 19, 2022 9:21 PM
> > > To: Matti Vaittinen <mazziesaccount@...il.com>; Matti Vaittinen
> > > <matti.vaittinen@...rohmeurope.com>
> > > Cc: Jonathan Cameron <jic23@...nel.org>; Lars-Peter Clausen
> > > <lars@...afoo.de>; Matti Vaittinen <mazziesaccount@...il.com>;
> > > Alexandru Ardelean <aardelean@...iqon.com>; linux-
> > > iio@...r.kernel.org; linux-kernel@...r.kernel.org
> > > Subject: [PATCH v3 13/14] iio: max1363: simplify using
> > > devm_regulator_get_enable()
> > > 
> > > [External]
> > > 
> > > Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(),
> > > add_action_or_reset(regulator_disable)' and use the
> > > devm_regulator_get_enable() and drop the pointer to the regulator.
> > > This simplifies code and makes it less tempting to add manual control
> > > for the regulator which is also controlled by devm.
> > > 
> > > Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
> > > 
> > > ---    
> > 
> > Acked-by: Nuno Sá <nuno.sa@...log.com>  
> 
> Applied.

This one was missing cleaning up the docs as well. fixed up.