linux-kernel - Re: [PATCH v2] scsi: mpi3mr: select CONFIG_SCSI_SAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Oct 2022 11:17:59 -0600
From:   Sathya Prakash Veerichetty <sathya.prakash@...adcom.com>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     mpi3mr-linuxdrv.pdl@...adcom.com,
        Kashyap Desai <kashyap.desai@...adcom.com>,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        James Bottomley <James.Bottomley@...senpartnership.com>
Subject: Re: [PATCH v2] scsi: mpi3mr: select CONFIG_SCSI_SAS_ATTRS

On Mon, Oct 17, 2022 at 8:55 AM Michal Kubecek <mkubecek@...e.cz> wrote:
>
> Starting with commit 42fc9fee116f ("scsi: mpi3mr: Add helper functions to
> manage device's port"), kernel configured with CONFIG_SCSI_MPI3MR=m and
> CONFIG_SCSI_SAS_ATTRS=n fails to build because modpost cannot find symbols
> used in mpi3mr_transport.c:
>
>   ERROR: modpost: "sas_port_alloc_num" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
>   ERROR: modpost: "sas_remove_host" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
>   ERROR: modpost: "sas_phy_alloc" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
>   ERROR: modpost: "sas_phy_free" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
>   ...
>
> Select CONFIG_SCSI_SAS_ATTRS when CONFIG_SCSI_MPI3MR is enabled to prevent
> inconsistent configs.
>
> Fixes: 42fc9fee116f ("scsi: mpi3mr: Add helper functions to manage device's port")
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
>
> v2: use select instead of depend
> ---
Acked-by: Sathya Prakash Veerichetty <sathya.prakash@...adcom.com>


>  drivers/scsi/mpi3mr/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/mpi3mr/Kconfig b/drivers/scsi/mpi3mr/Kconfig
> index 8997531940c2..f48740cd5b95 100644
> --- a/drivers/scsi/mpi3mr/Kconfig
> +++ b/drivers/scsi/mpi3mr/Kconfig
> @@ -4,5 +4,6 @@ config SCSI_MPI3MR
>         tristate "Broadcom MPI3 Storage Controller Device Driver"
>         depends on PCI && SCSI
>         select BLK_DEV_BSGLIB
> +       select SCSI_SAS_ATTRS
>         help
>         MPI3 based Storage & RAID Controllers Driver.
> --
> 2.38.0
>

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4227 bytes)