linux-kernel - Re: [PATCH v2] scsi: mpi3mr: select CONFIG_SCSI_SAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Oct 2022 23:52:22 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Kashyap Desai <kashyap.desai@...adcom.com>,
        Michal Kubecek <mkubecek@...e.cz>,
        Sathya Prakash Veerichetty <sathya.prakash@...adcom.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        mpi3mr-linuxdrv.pdl@...adcom.com,
        Sumit Saxena <sumit.saxena@...adcom.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        James Bottomley <James.Bottomley@...senPartnership.com>
Subject: Re: [PATCH v2] scsi: mpi3mr: select CONFIG_SCSI_SAS_ATTRS

On Mon, 17 Oct 2022 16:55:17 +0200 (CEST), Michal Kubecek wrote:

> Starting with commit 42fc9fee116f ("scsi: mpi3mr: Add helper functions to
> manage device's port"), kernel configured with CONFIG_SCSI_MPI3MR=m and
> CONFIG_SCSI_SAS_ATTRS=n fails to build because modpost cannot find symbols
> used in mpi3mr_transport.c:
> 
>   ERROR: modpost: "sas_port_alloc_num" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
>   ERROR: modpost: "sas_remove_host" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
>   ERROR: modpost: "sas_phy_alloc" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
>   ERROR: modpost: "sas_phy_free" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined!
>   ...
> 
> [...]

Applied to 6.1/scsi-fixes, thanks!

[1/1] scsi: mpi3mr: select CONFIG_SCSI_SAS_ATTRS
      https://git.kernel.org/mkp/scsi/c/65244389b1b3

-- 
Martin K. Petersen	Oracle Linux Engineering