linux-kernel - Re: [PATCH] dt-bindings: mfd: qcom,spmi-pmic: support rradc type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 16 Oct 2022 21:07:42 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Caleb Connolly <caleb.connolly@...aro.org>
Cc:     Luca Weiss <luca@...tu.xyz>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        devicetree@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lee Jones <lee@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH] dt-bindings: mfd: qcom,spmi-pmic: support rradc type

On 16/10/2022 13:57, Caleb Connolly wrote:
> 'adc@' nodes can also be the rradc.
> 
> Signed-off-by: Caleb Connolly <caleb.connolly@...aro.org>
> ---
> This patch is based on Luca's series:
> https://lore.kernel.org/linux-arm-msm/20220925211744.133947-2-luca@z3ntu.xyz/
> 
> Luca: feel free to apply this as a fixup if you re-send
> ---
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index b5a06c1b67bb..cba25562e1da 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -102,6 +102,7 @@ patternProperties:
>      oneOf:
>        - $ref: /schemas/iio/adc/qcom,spmi-iadc.yaml#
>        - $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml#
> +      - $ref: /schemas/iio/adc/qcom,spmi-rradc.yaml#

rradc seems to be present only on few specific PMICs, so we could
restrict it per compatible. Similarly like adc-tm is done.

>  
>    "^adc-tm@[0-9a-f]+$":
>      type: object

Best regards,
Krzysztof