linux-kernel - Re: [PATCH] drbd: Store op in drbd_peer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210180505.4o19ICYi-lkp@intel.com>
Date:   Tue, 18 Oct 2022 05:13:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Christoph Böhmwalder 
        <christoph.boehmwalder@...bit.com>, Jens Axboe <axboe@...nel.dk>
Cc:     kbuild-all@...ts.01.org, drbd-dev@...ts.linbit.com,
        linux-kernel@...r.kernel.org,
        Lars Ellenberg <lars.ellenberg@...bit.com>,
        Philipp Reisner <philipp.reisner@...bit.com>,
        linux-block@...r.kernel.org,
        Christoph Böhmwalder 
        <christoph.boehmwalder@...bit.com>,
        Joel Colledge <joel.colledge@...bit.com>
Subject: Re: [PATCH] drbd: Store op in drbd_peer_request

Hi Christoph,

I love your patch! Perhaps something to improve:

[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on linus/master v6.1-rc1 next-20221017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christoph-B-hmwalder/drbd-Store-op-in-drbd_peer_request/20221017-170252
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20221017090154.15696-1-christoph.boehmwalder%40linbit.com
patch subject: [PATCH] drbd: Store op in drbd_peer_request
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/56bd9760957a27a5899aba7d1f75d650c1ac7a15
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Christoph-B-hmwalder/drbd-Store-op-in-drbd_peer_request/20221017-170252
        git checkout 56bd9760957a27a5899aba7d1f75d650c1ac7a15
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/block/drbd/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/block/drbd/drbd_receiver.c: In function 'wire_flags_to_bio':
>> drivers/block/drbd/drbd_receiver.c:2411:23: warning: unused variable 'opf' [-Wunused-variable]
    2411 |         unsigned long opf = wire_flags_to_bio_op(dpf) |
         |                       ^~~
   drivers/block/drbd/drbd_receiver.c:2415:1: error: no return statement in function returning non-void [-Werror=return-type]
    2415 | }
         | ^
   cc1: some warnings being treated as errors


vim +/opf +2411 drivers/block/drbd/drbd_receiver.c

  2407	
  2408	/* see also bio_flags_to_wire() */
  2409	static unsigned long wire_flags_to_bio(struct drbd_connection *connection, u32 dpf)
  2410	{
> 2411		unsigned long opf = wire_flags_to_bio_op(dpf) |
  2412			(dpf & DP_RW_SYNC ? REQ_SYNC : 0) |
  2413			(dpf & DP_FUA ? REQ_FUA : 0) |
  2414			(dpf & DP_FLUSH ? REQ_PREFLUSH : 0);
  2415	}
  2416	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (291888 bytes)