linux-kernel - Re: [PATCH 1/2] nvmem: stm32: add warning when upper OTPs are updated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202210171843.mkDy8RxG-lkp@intel.com>
Date:   Mon, 17 Oct 2022 18:36:54 +0800
From:   kernel test robot <lkp@...el.com>
To:     Patrick Delaunay <patrick.delaunay@...s.st.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>
Cc:     kbuild-all@...ts.01.org,
        Patrick Delaunay <patrick.delaunay@...s.st.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH 1/2] nvmem: stm32: add warning when upper OTPs are updated

Hi Patrick,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on atorgue-stm32/stm32-next]
[also build test ERROR on linus/master v6.1-rc1 next-20221017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Patrick-Delaunay/nvmem-stm32-add-warning-when-upper-OTPs-are-updated/20221017-102514
base:   https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
patch link:    https://lore.kernel.org/r/20221014170426.1.Ifa806ff30d7c669ba9a3df9c6b64698a2dcc073a%40changeid
patch subject: [PATCH 1/2] nvmem: stm32: add warning when upper OTPs are updated
config: arc-randconfig-r023-20221017
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/2f808f51f933798336822a96450c2c2797c2acc6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Patrick-Delaunay/nvmem-stm32-add-warning-when-upper-OTPs-are-updated/20221017-102514
        git checkout 2f808f51f933798336822a96450c2c2797c2acc6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/gpio/ drivers/nvmem/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/nvmem/stm32-romem.c: In function 'stm32_bsec_write':
>> drivers/nvmem/stm32-romem.c:136:35: error: 'struct stm32_romem_priv' has no member named 'lower'
     136 |         if (offset + bytes >= priv->lower * 4)
         |                                   ^~


vim +136 drivers/nvmem/stm32-romem.c

   114	
   115	static int stm32_bsec_write(void *context, unsigned int offset, void *buf,
   116				    size_t bytes)
   117	{
   118		struct stm32_romem_priv *priv = context;
   119		struct device *dev = priv->cfg.dev;
   120		u32 *buf32 = buf;
   121		int ret, i;
   122	
   123		/* Allow only writing complete 32-bits aligned words */
   124		if ((bytes % 4) || (offset % 4))
   125			return -EINVAL;
   126	
   127		for (i = offset; i < offset + bytes; i += 4) {
   128			ret = stm32_bsec_smc(STM32_SMC_PROG_OTP, i >> 2, *buf32++,
   129					     NULL);
   130			if (ret) {
   131				dev_err(dev, "Can't write data%d (%d)\n", i >> 2, ret);
   132				return ret;
   133			}
   134		}
   135	
 > 136		if (offset + bytes >= priv->lower * 4)
   137			dev_warn(dev, "Update of upper OTPs with ECC protection (word programming, only once)\n");
   138	
   139		return 0;
   140	}
   141	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (145698 bytes)