linux-kernel - Re: [PATCH 2/2] clk: Add trace events for rate requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221018102409.594be3e4@gandalf.local.home>
Date:   Tue, 18 Oct 2022 10:24:09 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Maxime Ripard <maxime@...no.tech>
Cc:     Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH 2/2] clk: Add trace events for rate requests

On Tue, 18 Oct 2022 15:56:42 +0200
Maxime Ripard <maxime@...no.tech> wrote:

> It is currently fairly difficult to follow what clk_rate_request are
> issued, and how they have been modified once done.
> 
> Indeed, there's multiple paths that can be taken, some functions are
> recursive and will just forward the request to its parent, etc.
> 
> Adding a lot of debug prints is just not very convenient, so let's add
> trace events for the clock requests, one before they are submitted and
> one after they are returned.
> 
> That way we can simply toggle the tracing on without modifying the
> kernel code and without affecting performances or the kernel logs too
> much.
> 
> Signed-off-by: Maxime Ripard <maxime@...no.tech>

>From a tracing point of view:

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve

> ---
>  drivers/clk/clk.c          | 31 +++++++++++++++++++++++++++++++
>  include/trace/events/clk.h | 43 +++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 74 insertions(+)