linux-kernel - Re: [PATCH][V2] jfs: remove redundant assignments to ipaimap and ipaimap2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c02b2de-4fb3-1ad2-5a30-614f9550c108@oracle.com>
Date:   Tue, 18 Oct 2022 10:44:30 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        jfs-discussion@...ts.sourceforge.net
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] jfs: remove redundant assignments to ipaimap and
 ipaimap2

Looks good. Applied.

Thanks,
Shaggy

On 10/18/22 10:23AM, Colin Ian King wrote:
> The pointers ipaimap and ipaimap2 are re-assigned with values a second
> time with the same values when they were initialized. The re-assignments
> are redundant and can be removed.
> 
> Cleans up two clang scan build warnings:
> fs/jfs/jfs_umount.c:42:16: warning: Value stored to 'ipaimap' during
> its initialization is never read [deadcode.DeadStores]
> 
> fs/jfs/jfs_umount.c:43:16: warning: Value stored to 'ipaimap2' during
> its initialization is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
> V2: remove re-assignments rather than initializations as per the
>      recommendation from Dave Kleikamp
> ---
>   fs/jfs/jfs_umount.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/fs/jfs/jfs_umount.c b/fs/jfs/jfs_umount.c
> index 3e8b13e6aa01..95ebcd17ce75 100644
> --- a/fs/jfs/jfs_umount.c
> +++ b/fs/jfs/jfs_umount.c
> @@ -68,7 +68,6 @@ int jfs_umount(struct super_block *sb)
>   	/*
>   	 * close secondary aggregate inode allocation map
>   	 */
> -	ipaimap2 = sbi->ipaimap2;
>   	if (ipaimap2) {
>   		diUnmount(ipaimap2, 0);
>   		diFreeSpecial(ipaimap2);
> @@ -78,7 +77,6 @@ int jfs_umount(struct super_block *sb)
>   	/*
>   	 * close aggregate inode allocation map
>   	 */
> -	ipaimap = sbi->ipaimap;
>   	diUnmount(ipaimap, 0);
>   	diFreeSpecial(ipaimap);
>   	sbi->ipaimap = NULL;