lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Oct 2022 00:40:27 -0700 From: Christoph Hellwig <hch@...radead.org> To: Ye Bin <yebin10@...wei.com> Cc: axboe@...nel.dk, rostedt@...dmis.org, mhiramat@...nel.org, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH -next 1/3] blktrace: introduce 'blk_trace_swicth_state' helper On Mon, Oct 17, 2022 at 02:53:19PM +0800, Ye Bin wrote: > +static int blk_trace_switch_state(struct blk_trace *bt, int start) This is a very confusing helper. Please split it into two helpers (e.g. blk_trace_{start,stop}) instead of the awakward int used as boolean argument that makes it do two entirely unrelated things.
Powered by blists - more mailing lists