linux-kernel - Re: [PATCH -next 2/3] blktrace: fix possible memleak in '__blk_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e9c8d3a-6f23-a465-e070-5f963a95afe2@huaweicloud.com>
Date:   Tue, 18 Oct 2022 15:38:01 +0800
From:   Yu Kuai <yukuai1@...weicloud.com>
To:     Ye Bin <yebin10@...wei.com>, axboe@...nel.dk, rostedt@...dmis.org,
        mhiramat@...nel.org, linux-block@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH -next 2/3] blktrace: fix possible memleak in
 '__blk_trace_remove'

Hi,

在 2022/10/17 14:53, Ye Bin 写道:
> To solve above issues, reference commit '5afedf670caf', first stop block trace
> when block trace state is 'Blktrace_running' in '__blk_trace_remove'.

Will it be much simpler if we just return -EBUSY in blk_trace_remove if
state is still running?

And similar checking in blk_trace_setup.

Thanks,
Kuai