linux-kernel - Re: [PATCH v5 01/33] thermal/of: Rework the thermal device tree initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y06BCSh+jq5Ztf+3@shredder>
Date:   Tue, 18 Oct 2022 13:33:45 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Daniel Lezcano <daniel.lezcano@...exp.org>
Cc:     daniel.lezcano@...aro.org, rafael@...nel.org, rui.zhang@...el.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        khilman@...libre.com, abailon@...libre.com, lukasz.luba@....com,
        broonie@...nel.org, damien.lemoal@...nsource.wdc.com,
        heiko@...ech.de, hayashi.kunihiko@...ionext.com,
        mhiramat@...nel.org, talel@...zon.com, thierry.reding@...il.com,
        digetx@...il.com, jonathanh@...dia.com, anarsoul@...il.com,
        tiny.windzz@...il.com, baolin.wang7@...il.com,
        f.fainelli@...il.com, bjorn.andersson@...aro.org,
        mcoquelin.stm32@...il.com, glaroque@...libre.com,
        miquel.raynal@...tlin.com, shawnguo@...nel.org,
        niklas.soderlund@...natech.se, matthias.bgg@...il.com,
        j-keerthy@...com, Amit Kucheria <amitk@...nel.org>
Subject: Re: [PATCH v5 01/33] thermal/of: Rework the thermal device tree
 initialization

On Tue, Oct 18, 2022 at 01:29:04PM +0300, Ido Schimmel wrote:
> diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
> index d4b6335ace15..43d55c29a29a 100644
> --- a/drivers/thermal/thermal_of.c
> +++ b/drivers/thermal/thermal_of.c
> @@ -604,13 +604,15 @@ struct thermal_zone_device *thermal_of_zone_register(struct device_node *sensor,
>         if (IS_ERR(np)) {
>                 if (PTR_ERR(np) != -ENODEV)
>                         pr_err("Failed to find thermal zone for %pOFn id=%d\n", sensor, id);
> -               return ERR_CAST(np);
> +               ret = PTR_ERR(np);
> +               goto out_kfree_of_ops;
>         }
>  
>         trips = thermal_of_trips_init(np, &ntrips);
>         if (IS_ERR(trips)) {
>                 pr_err("Failed to find trip points for %pOFn id=%d\n", sensor, id);
> -               return ERR_CAST(trips);
> +               ret = PTR_ERR(np);

Sorry, should be:

ret = PTR_ERR(trips);

> +               goto out_kfree_of_ops;
>         }
>  
>         ret = thermal_of_monitor_init(np, &delay, &pdelay);
> @@ -659,6 +661,8 @@ struct thermal_zone_device *thermal_of_zone_register(struct device_node *sensor,
>         kfree(tzp);
>  out_kfree_trips:
>         kfree(trips);
> +out_kfree_of_ops:
> +       kfree(of_ops);
>  
>         return ERR_PTR(ret);
>  }