linux-kernel - Re: [PATCH 2/2] mtd: core: set ROOT_DEV for partitions marked as root devices in DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8d12dd0-7504-0198-dacb-b3723d82fc60@gmail.com>
Date:   Wed, 19 Oct 2022 13:53:15 +0200
From:   Rafał Miłecki <zajec5@...il.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Mikhail Zhilkin <csharper2005@...il.com>,
        Christian Marangi <ansuelsmth@...il.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Chaitanya Kulkarni <kch@...dia.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Jens Axboe <axboe@...nel.dk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH 2/2] mtd: core: set ROOT_DEV for partitions marked as root
 devices in DT

On 19.10.2022 13:50, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
> 
> This adds support for "linux,root-device" binding that is used to mark
> root device MTD partition. It's useful for devices using device tree
> that don't have bootloader passing root info in cmdline.
> 
> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
> ---
>   drivers/mtd/mtdcore.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index 07249af4f890..034b06aff660 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -28,6 +28,7 @@
>   #include <linux/leds.h>
>   #include <linux/debugfs.h>
>   #include <linux/nvmem-provider.h>
> +#include <linux/root_dev.h>
>   
>   #include <linux/mtd/mtd.h>
>   #include <linux/mtd/partitions.h>
> @@ -735,6 +736,12 @@ int add_mtd_device(struct mtd_info *mtd)
>   		not->add(mtd);
>   
>   	mutex_unlock(&mtd_table_mutex);
> +
> +	if (of_find_property(mtd_get_of_node(mtd), "linux,rootfs", NULL)) {

I forgot to re-do "format-patch" after "commit --amend".
s/linux,rootfs/linux,root-device/

I'll fix that in V2 after giving this patchset some time to review.


> +		pr_info("mtd: setting mtd%d (%s) as root device\n", mtd->index, mtd->name);
> +		ROOT_DEV = MKDEV(MTD_BLOCK_MAJOR, mtd->index);
> +	}
> +
>   	/* We _know_ we aren't being removed, because
>   	   our caller is still holding us here. So none
>   	   of this try_ nonsense, and no bitching about it