linux-kernel - Re: [PATCH 2/2] mtd: core: set ROOT_DEV for partitions marked as root devices in DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221021015006.GA2145299-robh@kernel.org>
Date:   Thu, 20 Oct 2022 20:50:06 -0500
From:   Rob Herring <robh@...nel.org>
To:     Rafał Miłecki <zajec5@...il.com>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Mikhail Zhilkin <csharper2005@...il.com>,
        Christian Marangi <ansuelsmth@...il.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Chaitanya Kulkarni <kch@...dia.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Jens Axboe <axboe@...nel.dk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH 2/2] mtd: core: set ROOT_DEV for partitions marked as
 root devices in DT

On Wed, Oct 19, 2022 at 01:53:15PM +0200, Rafał Miłecki wrote:
> On 19.10.2022 13:50, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@...ecki.pl>
> > 
> > This adds support for "linux,root-device" binding that is used to mark
> > root device MTD partition. It's useful for devices using device tree
> > that don't have bootloader passing root info in cmdline.
> > 
> > Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
> > ---
> >   drivers/mtd/mtdcore.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> > 
> > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> > index 07249af4f890..034b06aff660 100644
> > --- a/drivers/mtd/mtdcore.c
> > +++ b/drivers/mtd/mtdcore.c
> > @@ -28,6 +28,7 @@
> >   #include <linux/leds.h>
> >   #include <linux/debugfs.h>
> >   #include <linux/nvmem-provider.h>
> > +#include <linux/root_dev.h>
> >   #include <linux/mtd/mtd.h>
> >   #include <linux/mtd/partitions.h>
> > @@ -735,6 +736,12 @@ int add_mtd_device(struct mtd_info *mtd)
> >   		not->add(mtd);
> >   	mutex_unlock(&mtd_table_mutex);
> > +
> > +	if (of_find_property(mtd_get_of_node(mtd), "linux,rootfs", NULL)) {
> 
> I forgot to re-do "format-patch" after "commit --amend".
> s/linux,rootfs/linux,root-device/

It's really the filesystem you are tagging, not a device, so I think 
'linux,rootfs' is better.

Rob