[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <yq1h6zzz740.fsf@ca-mkp.ca.oracle.com>
Date: Wed, 19 Oct 2022 20:18:03 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Xingui Yang <yangxingui@...wei.com>
Cc: <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linuxarm@...wei.com>, <prime.zeng@...ilicon.com>,
<kangfenglong@...wei.com>, <john.garry@...wei.com>
Subject: Re: [PATCH] scsi: sd: Update dix config everytime
sd_revalidate_disk is called
Xingui,
> When the host protection capabilities are 0x77 and a DIF disk is
> connected, the DIX and DIF of the disk are default enabled. Then if
> that DIF disk is reformatted as a non-DIF format, per the currently
> flow, the DIX is kept enabled which is not correct
DIX is orthogonal to DIF and a host property. DIX should not be disabled
just because the disk is no longer formatted with protection
information.
That said, your patch is probably fine. I'll take a closer look
tomorrow.
--
Martin K. Petersen Oracle Linux Engineering
Powered by blists - more mailing lists