linux-kernel - Re: [PATCH] scsi: sd: Update dix config everytime sd_revalidate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <106d4377-1ba6-7970-b930-de3d766f3dd9@huawei.com>
Date:   Sat, 22 Oct 2022 10:52:05 +0800
From:   yangxingui <yangxingui@...wei.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     <jejb@...ux.ibm.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
        <prime.zeng@...ilicon.com>, <kangfenglong@...wei.com>,
        <john.garry@...wei.com>
Subject: Re: [PATCH] scsi: sd: Update dix config everytime sd_revalidate_disk
 is called


On 2022/10/20 8:18, Martin K. Petersen wrote:
> Xingui,
>
>> When the host protection capabilities are 0x77 and a DIF disk is
>> connected, the DIX and DIF of the disk are default enabled. Then if
>> that DIF disk is reformatted as a non-DIF format, per the currently
>> flow, the DIX is kept enabled which is not correct
> DIX is orthogonal to DIF and a host property. DIX should not be disabled
> just because the disk is no longer formatted with protection
> information.

As the host protection capabilities are 0x77 and not support DIX between 
OS and HBA only.

If write command is delivered to a non-DIF disk with DIX format this 
time, I/Os will be failed.

DIX status should  be updated when the disk DIF type changes.

>
> That said, your patch is probably fine. I'll take a closer look
> tomorrow.

ok, thanks.

Xingui

>