[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <66c9f444-ef8f-c56a-0b95-ed39715e4a75@huawei.com>
Date: Tue, 29 Nov 2022 10:45:55 +0800
From: yangxingui <yangxingui@...wei.com>
To: "Martin K. Petersen" <martin.petersen@...cle.com>
CC: <jejb@...ux.ibm.com>, <linux-scsi@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
<prime.zeng@...ilicon.com>, <kangfenglong@...wei.com>,
<john.garry@...wei.com>
Subject: Re: [PATCH] scsi: sd: Update dix config everytime sd_revalidate_disk
is called
On 2022/10/20 8:18, Martin K. Petersen wrote:
>
> Xingui,
>
>> When the host protection capabilities are 0x77 and a DIF disk is
>> connected, the DIX and DIF of the disk are default enabled. Then if
>> that DIF disk is reformatted as a non-DIF format, per the currently
>> flow, the DIX is kept enabled which is not correct
>
> DIX is orthogonal to DIF and a host property. DIX should not be disabled
> just because the disk is no longer formatted with protection
> information.
>
> That said, your patch is probably fine. I'll take a closer look
> tomorrow.
>
Friendly ping... Do you have other suggestions?
Thanks,
Xingui
Powered by blists - more mailing lists