linux-kernel - Re: [PATCH 1/3] staging: rtl8723bs: fix white space warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Oct 2022 09:34:07 +0530
From:   Praveen Kumar <kumarpraveen@...ux.microsoft.com>
To:     Emily Peri <eperi1024@...il.com>, gregkh@...uxfoundation.org,
        outreachy@...ts.linux.dev, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8723bs: fix white space warnings

On 20-10-2022 07:40, Emily Peri wrote:
> Fix the following checkpatch warnings in rtw_ioctl_set:
> 1) Add missing blankline after declaration
> 2) Replace spaces used for indent with tab
> 3) Remove space before tab
> 
> Signed-off-by: Emily Peri <eperi1024@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> index 8c11daff2d59..354e61a8f2bd 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> @@ -78,6 +78,7 @@ u8 rtw_do_join(struct adapter *padapter)
>  		goto exit;
>  	} else {
>  		int select_ret;
> +
>  		spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));
>  		select_ret = rtw_select_and_join_from_scanned_queue(pmlmepriv);
>  		if (select_ret == _SUCCESS) {
> @@ -311,7 +312,7 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter,
>  		if ((*pold_state == Ndis802_11Infrastructure) || (*pold_state == Ndis802_11IBSS)) {
>  			if (check_fwstate(pmlmepriv, _FW_LINKED) == true)
>  				rtw_indicate_disconnect(padapter); /* will clr Linked_state; before this function, we must have checked whether issue dis-assoc_cmd or not */
> -	       }
> +		}

I think indentation is wrong here, it should be only 1 tab instead of 2 tabs ?

>  
>  		*pold_state = networktype;
>  
> @@ -367,7 +368,7 @@ u8 rtw_set_802_11_disassociate(struct adapter *padapter)
>  
>  u8 rtw_set_802_11_bssid_list_scan(struct adapter *padapter, struct ndis_802_11_ssid *pssid, int ssid_max_num)
>  {
> -	struct	mlme_priv 	*pmlmepriv = &padapter->mlmepriv;
> +	struct	mlme_priv	*pmlmepriv = &padapter->mlmepriv;
>  	u8 res = true;
>  
>  	if (!padapter) {

Regards,

~Praveen.