[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202210201217.nFPmSxcE-lkp@intel.com>
Date: Thu, 20 Oct 2022 12:17:08 +0800
From: kernel test robot <lkp@...el.com>
To: Christian Brauner <brauner@...nel.org>
Cc: kbuild-all@...ts.01.org, Ammar Faizi <ammarfaizi2@...weeb.org>,
GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
linux-doc@...r.kernel.org
Subject: [ammarfaizi2-block:brauner/linux/fs.acl.rework 3/30] htmldocs:
Documentation/filesystems/locking.rst:107: WARNING: Malformed table.
Hi Christian,
FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
tree: https://github.com/ammarfaizi2/linux-block brauner/linux/fs.acl.rework
head: baac47dc33766dfb02917cba69b698f1a9fd1f84
commit: 9c3326476632b739e6d01b4dd52bb3b56613eecc [3/30] fs: rename current get acl method
reproduce:
# https://github.com/ammarfaizi2/linux-block/commit/9c3326476632b739e6d01b4dd52bb3b56613eecc
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block brauner/linux/fs.acl.rework
git checkout 9c3326476632b739e6d01b4dd52bb3b56613eecc
make menuconfig
# enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS, CONFIG_WARN_ABI_ERRORS
make htmldocs
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> Documentation/filesystems/locking.rst:107: WARNING: Malformed table.
vim +107 Documentation/filesystems/locking.rst
58
59 int (*create) (struct inode *,struct dentry *,umode_t, bool);
60 struct dentry * (*lookup) (struct inode *,struct dentry *, unsigned int);
61 int (*link) (struct dentry *,struct inode *,struct dentry *);
62 int (*unlink) (struct inode *,struct dentry *);
63 int (*symlink) (struct inode *,struct dentry *,const char *);
64 int (*mkdir) (struct inode *,struct dentry *,umode_t);
65 int (*rmdir) (struct inode *,struct dentry *);
66 int (*mknod) (struct inode *,struct dentry *,umode_t,dev_t);
67 int (*rename) (struct inode *, struct dentry *,
68 struct inode *, struct dentry *, unsigned int);
69 int (*readlink) (struct dentry *, char __user *,int);
70 const char *(*get_link) (struct dentry *, struct inode *, struct delayed_call *);
71 void (*truncate) (struct inode *);
72 int (*permission) (struct inode *, int, unsigned int);
73 struct posix_acl * (*get_inode_acl)(struct inode *, int, bool);
74 int (*setattr) (struct dentry *, struct iattr *);
75 int (*getattr) (const struct path *, struct kstat *, u32, unsigned int);
76 ssize_t (*listxattr) (struct dentry *, char *, size_t);
77 int (*fiemap)(struct inode *, struct fiemap_extent_info *, u64 start, u64 len);
78 void (*update_time)(struct inode *, struct timespec *, int);
79 int (*atomic_open)(struct inode *, struct dentry *,
80 struct file *, unsigned open_flag,
81 umode_t create_mode);
82 int (*tmpfile) (struct user_namespace *, struct inode *,
83 struct file *, umode_t);
84 int (*fileattr_set)(struct user_namespace *mnt_userns,
85 struct dentry *dentry, struct fileattr *fa);
86 int (*fileattr_get)(struct dentry *dentry, struct fileattr *fa);
87
88 locking rules:
89 all may block
90
91 ============= =============================================
92 ops i_rwsem(inode)
93 ============= =============================================
94 lookup: shared
95 create: exclusive
96 link: exclusive (both)
97 mknod: exclusive
98 symlink: exclusive
99 mkdir: exclusive
100 unlink: exclusive (both)
101 rmdir: exclusive (both)(see below)
102 rename: exclusive (all) (see below)
103 readlink: no
104 get_link: no
105 setattr: exclusive
106 permission: no (may not block if called in rcu-walk mode)
> 107 get_inode_acl: no
108 getattr: no
109 listxattr: no
110 fiemap: no
111 update_time: no
112 atomic_open: shared (exclusive if O_CREAT is set in open flags)
113 tmpfile: no
114 fileattr_get: no or exclusive
115 fileattr_set: exclusive
116 ============= =============================================
117
118
119 Additionally, ->rmdir(), ->unlink() and ->rename() have ->i_rwsem
120 exclusive on victim.
121 cross-directory ->rename() has (per-superblock) ->s_vfs_rename_sem.
122
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (38870 bytes)
Powered by blists - more mailing lists