linux-kernel - RE: [PATCH 2/2] dt-bindings: rtc: add bindings for max313xx RTCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM8PR03MB6247FE3C128DE9FE5BF6F591962A9@DM8PR03MB6247.namprd03.prod.outlook.com>
Date:   Thu, 20 Oct 2022 14:25:30 +0000
From:   "Tilki, Ibrahim" <Ibrahim.Tilki@...log.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC:     "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "jdelvare@...e.com" <jdelvare@...e.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "Arslanbenzer, Zeynep" <Zeynep.Arslanbenzer@...log.com>
Subject: RE: [PATCH 2/2] dt-bindings: rtc: add bindings for max313xx RTCs


> On Wed, Oct 19, 2022 at 10:34:15AM -0400, Krzysztof Kozlowski wrote:
> > On 19/10/2022 09:39, Ibrahim Tilki wrote:
> > > Devicetree binding documentation for Analog Devices MAX313XX RTCs
> > > 
> > > Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@...log.com>
> > > Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@...log.com>
> > > ---
> > > .../devicetree/bindings/rtc/adi,max313xx.yaml | 163 ++++++++++++++++++
> > > 1 file changed, 163 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml \
> > > b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml new file mode 100644
> > > index 000000000..1aa491799
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> > > @@ -0,0 +1,163 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +# Copyright 2022 Analog Devices Inc.
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/rtc/adi,max313xx.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Analog Devices MAX313XX series I2C RTC driver
> > 
> > Drop "driver" unless it is some hardware-related term.
> > 
> > > +
> > > +maintainers:
> > > +  - Ibrahim Tilki <Ibrahim.Tilki@...log.com>
> > > +  - Zeynep Arslanbenzer <Zeynep.Arslanbenzer@...log.com>
> > > +
> > > +description: Bindings for the Analog Devices MAX313XX series RTCs.
> > 
> > Drop "Bindings for"
> > 
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - adi,max31328
> > > +      - adi,max31329
> > > +      - adi,max31331
> > > +      - adi,max31334
> > > +      - adi,max31341
> > > +      - adi,max31342
> > > +      - adi,max31343
> > 
> > This looked familiar... and indeed it is.
> > 
> > https://lore.kernel.org/all/a382fdee-3672-50b8-cd58-85563b9d9079@linaro.org/
> > 
> > Where is the changelog? What are the differences? How can we understand
> > what is happening here?
> > 
> 
> I hope that other submission was an error; otherwise it tried to sneak in
> the bindings for max313xx under an unrelated subject.
> 
> Guenter

This binding was included in the v6 of max11410 patch by mistake and I
mentioned it in v8 cover letter:

https://lore.kernel.org/all/20221003105903.229-1-Ibrahim.Tilki@analog.com/

I still addressed your comments but did not include a changelog since
this is the first patch of a new series.

I'm sorry for the confusion.

Ibrahim