linux-kernel - RE: [PATCH 1/2] drivers: rtc: add max313xx series rtc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM8PR03MB624786DEF5E135986ECB7B1F962A9@DM8PR03MB6247.namprd03.prod.outlook.com>
Date:   Thu, 20 Oct 2022 14:47:25 +0000
From:   "Tilki, Ibrahim" <Ibrahim.Tilki@...log.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "jdelvare@...e.com" <jdelvare@...e.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>
CC:     "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "Arslanbenzer, Zeynep" <Zeynep.Arslanbenzer@...log.com>
Subject: RE: [PATCH 1/2] drivers: rtc: add max313xx series rtc driver

...

> > +
> > +static int max313xx_wdt_ping(struct watchdog_device *wdd)
> > +{
> > +	int ret;
> > +
> > +	ret = max313xx_wdt_stop(wdd);
> > +	if (ret)
> > +		return ret;
> > +
> > +	return max313xx_wdt_start(wdd);
> 
> Having to stop a watchdog just to ping it is unusual. Is this really
> necessary ?
> 

Unfortunately RTCs do not have any other way of resetting timer counter
other than restarting the timer.

Ibrahim

> > +}
> > +

...