lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y1MMeH4sZCaqzdUA@dev-arch.thelio-3990X>
Date:   Fri, 21 Oct 2022 14:17:44 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     Miguel Ojeda <ojeda@...nel.org>
Cc:     Andrey Konovalov <andreyknvl@...il.com>,
        Marco Elver <elver@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Arnd Bergmann <arnd@...db.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Uros Bizjak <ubizjak@...il.com>,
        Dan Li <ashimida@...ux.alibaba.com>,
        Alexander Potapenko <glider@...gle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] compiler-gcc: be consistent with underscores use for
 `no_sanitize`

On Fri, Oct 21, 2022 at 01:59:52PM +0200, Miguel Ojeda wrote:
> Other macros that define shorthands for attributes in e.g.
> `compiler_attributes.h` and elsewhere use underscores.
> 
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

> ---
>  include/linux/compiler-gcc.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index f55a37efdb97..b9530d3515ac 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -83,25 +83,25 @@
>  #endif
>  
>  #if __has_attribute(__no_sanitize_address__)
> -#define __no_sanitize_address __attribute__((no_sanitize_address))
> +#define __no_sanitize_address __attribute__((__no_sanitize_address__))
>  #else
>  #define __no_sanitize_address
>  #endif
>  
>  #if defined(__SANITIZE_THREAD__) && __has_attribute(__no_sanitize_thread__)
> -#define __no_sanitize_thread __attribute__((no_sanitize_thread))
> +#define __no_sanitize_thread __attribute__((__no_sanitize_thread__))
>  #else
>  #define __no_sanitize_thread
>  #endif
>  
>  #if __has_attribute(__no_sanitize_undefined__)
> -#define __no_sanitize_undefined __attribute__((no_sanitize_undefined))
> +#define __no_sanitize_undefined __attribute__((__no_sanitize_undefined__))
>  #else
>  #define __no_sanitize_undefined
>  #endif
>  
>  #if defined(CONFIG_KCOV) && __has_attribute(__no_sanitize_coverage__)
> -#define __no_sanitize_coverage __attribute__((no_sanitize_coverage))
> +#define __no_sanitize_coverage __attribute__((__no_sanitize_coverage__))
>  #else
>  #define __no_sanitize_coverage
>  #endif
> 
> base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
> -- 
> 2.38.1
> 
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ