lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y1MMlE3A2Gdw599+@dev-arch.thelio-3990X>
Date:   Fri, 21 Oct 2022 14:18:12 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     Miguel Ojeda <ojeda@...nel.org>
Cc:     Andrey Konovalov <andreyknvl@...il.com>,
        Marco Elver <elver@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Arnd Bergmann <arnd@...db.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Uros Bizjak <ubizjak@...il.com>,
        Dan Li <ashimida@...ux.alibaba.com>,
        Alexander Potapenko <glider@...gle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] compiler-gcc: remove attribute support check for
 `__no_sanitize_address__`

On Fri, Oct 21, 2022 at 01:59:53PM +0200, Miguel Ojeda wrote:
> The attribute was added in GCC 4.8, while the minimum GCC version
> supported by the kernel is GCC 5.1.
> 
> Therefore, remove the check.
> 
> Link: https://godbolt.org/z/84v56vcn8
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

> ---
>  include/linux/compiler-gcc.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index b9530d3515ac..bfce7f4d0978 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -82,11 +82,7 @@
>  #define __noscs __attribute__((__no_sanitize__("shadow-call-stack")))
>  #endif
>  
> -#if __has_attribute(__no_sanitize_address__)
>  #define __no_sanitize_address __attribute__((__no_sanitize_address__))
> -#else
> -#define __no_sanitize_address
> -#endif
>  
>  #if defined(__SANITIZE_THREAD__) && __has_attribute(__no_sanitize_thread__)
>  #define __no_sanitize_thread __attribute__((__no_sanitize_thread__))
> -- 
> 2.38.1
> 
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ