linux-kernel - Re: [PATCH -next] block: fix memory leak for elevator on add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1IWTOO1RUIOZJQN@T590>
Date:   Fri, 21 Oct 2022 11:47:24 +0800
From:   Ming Lei <ming.lei@...hat.com>
To:     Yu Kuai <yukuai1@...weicloud.com>
Cc:     hch@....de, axboe@...nel.dk, damien.lemoal@....com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        yukuai3@...wei.com, yi.zhang@...wei.com
Subject: Re: [PATCH -next] block: fix memory leak for elevator on add_disk
 failure

On Fri, Oct 21, 2022 at 11:39:50AM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@...wei.com>
> 
> The default elevator is allocated in the begining of device_add_disk(),
> however, it's not freed in the following error path.
> 
> Fixes: 737eb78e82d5 ("block: Delay default elevator initialization")

Originally elevator can be teardown in disk release, or queue release
earlier time, so the fixes tag should be:

Fixes: 50e34d78815e ("block: disable the elevator int del_gendisk")


Thanks, 
Ming