linux-kernel - Re: [PATCH v2 1/1] mm/page_isolation: fix clang deadcode warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d00d6e23-6e4f-074f-67c3-5f00e8a913d2@redhat.com>
Date:   Fri, 21 Oct 2022 08:54:56 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Maria Yu <quic_aiquny@...cinc.com>, akpm@...ux-foundation.org,
        ziy@...dia.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org
Cc:     mike.kravetz@...cle.com, opendmb@...il.com
Subject: Re: [PATCH v2 1/1] mm/page_isolation: fix clang deadcode warning

On 21.10.22 07:19, Maria Yu wrote:
> When !CONFIG_VM_BUG_ON, there is warning of
> clang-analyzer-deadcode.DeadStores:
> Value stored to 'mt' during its initialization
> is never read.
> 
> Signed-off-by: Maria Yu <quic_aiquny@...cinc.com>
> ---
>   mm/page_isolation.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/page_isolation.c b/mm/page_isolation.c
> index 04141a9bea70..a7a478a22123 100644
> --- a/mm/page_isolation.c
> +++ b/mm/page_isolation.c
> @@ -330,9 +330,8 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags,
>   				      zone->zone_start_pfn);
>   
>   	if (skip_isolation) {
> -		int mt = get_pageblock_migratetype(pfn_to_page(isolate_pageblock));

__maybe_unused should work as well. Was that considered?

-- 
Thanks,

David / dhildenb