linux-kernel - Re: [PATCH v2 1/1] mm/page_isolation: fix clang deadcode warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1dd08ecb-2b08-0556-64ac-3f39a8fec76c@quicinc.com>
Date:   Fri, 21 Oct 2022 16:21:26 +0800
From:   "Aiqun(Maria) Yu" <quic_aiquny@...cinc.com>
To:     David Hildenbrand <david@...hat.com>, <akpm@...ux-foundation.org>,
        <ziy@...dia.com>, <linux-kernel@...r.kernel.org>,
        <linux-mm@...ck.org>
CC:     <mike.kravetz@...cle.com>, <opendmb@...il.com>
Subject: Re: [PATCH v2 1/1] mm/page_isolation: fix clang deadcode warning

On 10/21/2022 2:54 PM, David Hildenbrand wrote:
> On 21.10.22 07:19, Maria Yu wrote:
>> When !CONFIG_VM_BUG_ON, there is warning of
>> clang-analyzer-deadcode.DeadStores:
>> Value stored to 'mt' during its initialization
>> is never read.
>>
>> Signed-off-by: Maria Yu <quic_aiquny@...cinc.com>
>> ---
>>   mm/page_isolation.c | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/page_isolation.c b/mm/page_isolation.c
>> index 04141a9bea70..a7a478a22123 100644
>> --- a/mm/page_isolation.c
>> +++ b/mm/page_isolation.c
>> @@ -330,9 +330,8 @@ static int isolate_single_pageblock(unsigned long 
>> boundary_pfn, int flags,
>>                         zone->zone_start_pfn);
>>       if (skip_isolation) {
>> -        int mt = 
>> get_pageblock_migratetype(pfn_to_page(isolate_pageblock));
> 
> __maybe_unused should work as well. Was that considered?
> 
good idea.

-- 
Thx and BRs,
Aiqun(Maria) Yu