linux-kernel - Re: [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y1PFaOEbPVDN7313@kroah.com>
Date:   Sat, 22 Oct 2022 12:26:48 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     patrice.chotard@...s.st.com
Cc:     Felipe Balbi <balbi@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jerome Audu <jerome.audu@...com>,
        Felipe Balbi <felipe@...bi.sh>
Subject: Re: [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of
 name

On Fri, Sep 30, 2022 at 04:20:18PM +0200, patrice.chotard@...s.st.com wrote:
> From: Patrice Chotard <patrice.chotard@...s.st.com>
> 
> To ensure that child node is found, don't rely on child's node name
> which can take different value, but on child's compatible name.
> 
> Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name")
> Cc: Jerome Audu <jerome.audu@...com>
> Reported-by: Felipe Balbi <felipe@...bi.sh>
> Signed-off-by: Patrice Chotard <patrice.chotard@...s.st.com>
> ---
> v3: - rebase on correct branch
> v2: - add missing reported-by
>     - add Fixes
> ---
>  drivers/usb/dwc3/dwc3-st.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
> index 6c14a79279f9..fea5290de83f 100644
> --- a/drivers/usb/dwc3/dwc3-st.c
> +++ b/drivers/usb/dwc3/dwc3-st.c
> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
>  	/* Manage SoftReset */
>  	reset_control_deassert(dwc3_data->rstc_rst);
>  
> -	child = of_get_child_by_name(node, "usb");
> +	child = of_get_compatible_child(node, "snps,dwc3");
>  	if (!child) {
>  		dev_err(&pdev->dev, "failed to find dwc3 core node\n");
>  		ret = -ENODEV;
> -- 
> 2.25.1
> 

Is this still needed for 6.1-final?

thanks,

greg k-h