linux-kernel - [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220930142018.890535-1-patrice.chotard@foss.st.com>
Date:   Fri, 30 Sep 2022 16:20:18 +0200
From:   <patrice.chotard@...s.st.com>
To:     Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <patrice.chotard@...s.st.com>, Jerome Audu <jerome.audu@...com>,
        "Felipe Balbi" <felipe@...bi.sh>
Subject: [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name

From: Patrice Chotard <patrice.chotard@...s.st.com>

To ensure that child node is found, don't rely on child's node name
which can take different value, but on child's compatible name.

Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name")
Cc: Jerome Audu <jerome.audu@...com>
Reported-by: Felipe Balbi <felipe@...bi.sh>
Signed-off-by: Patrice Chotard <patrice.chotard@...s.st.com>
---
v3: - rebase on correct branch
v2: - add missing reported-by
    - add Fixes
---
 drivers/usb/dwc3/dwc3-st.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
index 6c14a79279f9..fea5290de83f 100644
--- a/drivers/usb/dwc3/dwc3-st.c
+++ b/drivers/usb/dwc3/dwc3-st.c
@@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
 	/* Manage SoftReset */
 	reset_control_deassert(dwc3_data->rstc_rst);
 
-	child = of_get_child_by_name(node, "usb");
+	child = of_get_compatible_child(node, "snps,dwc3");
 	if (!child) {
 		dev_err(&pdev->dev, "failed to find dwc3 core node\n");
 		ret = -ENODEV;
-- 
2.25.1