linux-kernel - Re: [PATCH v2] block: fix memory leak for elevator on add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Oct 2022 16:51:30 +0800
From:   Jason Yan <yanaijie@...weicloud.com>
To:     Yu Kuai <yukuai1@...weicloud.com>, axboe@...nel.dk, hch@....de,
        ming.lei@...hat.com
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        yukuai3@...wei.com, yi.zhang@...wei.com
Subject: Re: [PATCH v2] block: fix memory leak for elevator on add_disk
 failure


On 2022/10/22 10:16, Yu Kuai wrote:
> From: Yu Kuai<yukuai3@...wei.com>
> 
> The default elevator is allocated in the beginning of device_add_disk(),
> however, it's not freed in the following error path.
> 
> Fixes: 50e34d78815e ("block: disable the elevator int del_gendisk")
> Signed-off-by: Yu Kuai<yukuai3@...wei.com>
> Reviewed-by: Christoph Hellwig<hch@....de>
> ---
> Changes in v2:
>   - fix wrong fix tag
>   - add review tag
> 
>   block/genhd.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)

Reviewed-by: Jason Yan <yanaijie@...wei.com>