linux-kernel - Re: [GIT PULL] x86/urgent for 6.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Oct 2022 11:42:25 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Borislav Petkov <bp@...e.de>
Cc:     x86-ml <x86@...nel.org>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] x86/urgent for 6.1

On Sun, Oct 23, 2022 at 11:14 AM Borislav Petkov <bp@...e.de> wrote:
>
> I was gonna say, let's have a fixed tag name so that there are no
> multiple tags with the same name, per chance, which would confuse.

Several trees do that already, and jst call the tags "for-linus" or similar.

> But it seems that when you pull a tag, it remains a remote tag and
> doesn't appear in your tree.

I obviously don't want to distribute these temporary tags as tags, no.
That's a git default behavior thing, because it would be very annoying
to get hundreds of irrelevant tags that get distributed with the
kernel.

But the tag name does show up in the commit message itself, so it now
does show up in the logs:

    Merge tag 'x86_urgent_for_v6.0_rc2' of
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

    Pull x86 fixes from Borislav Petkov:
     "As usually the case, right after a major release, the tip urgent
      branches accumulate a couple more fixes than normal. And here is the
      x86, a bit bigger, urgent pile.
    ...

and you can see it even more if you do

    git show --show-signature 295dad10bfb5

(or "git cat-file commit 295dad10bfb5) which will show some details
that are normally suppressed by a plain "git log".

And that's the part I mean when I said "Nobody will look at the tag
name afterwards". Yes, there are signs of that incorrect tag name in
there, but it's not like I suspect anybody would have ever even
noticed hadn't you brought it up.

                 Linus