linux-kernel - RE: [PATCH v2 2/5] iio: temperature: ltc2983: make bulk write buffer DMA-safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR03MB6778C8AD805504AFBED97E1B992E9@SJ0PR03MB6778.namprd03.prod.outlook.com>
Date:   Mon, 24 Oct 2022 06:35:15 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     Jonathan Cameron <jic23@...nel.org>,
        Cosmin Tanislav <demonsingur@...il.com>
CC:     Lars-Peter Clausen <lars@...afoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Tanislav, Cosmin" <Cosmin.Tanislav@...log.com>
Subject: RE: [PATCH v2 2/5] iio: temperature: ltc2983: make bulk write buffer
 DMA-safe



> -----Original Message-----
> From: Jonathan Cameron <jic23@...nel.org>
> Sent: Sunday, October 23, 2022 2:43 PM
> To: Cosmin Tanislav <demonsingur@...il.com>
> Cc: Sa, Nuno <Nuno.Sa@...log.com>; Lars-Peter Clausen
> <lars@...afoo.de>; Hennerich, Michael <Michael.Hennerich@...log.com>;
> Rob Herring <robh+dt@...nel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@...aro.org>; linux-iio@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; Tanislav, Cosmin
> <Cosmin.Tanislav@...log.com>
> Subject: Re: [PATCH v2 2/5] iio: temperature: ltc2983: make bulk write buffer
> DMA-safe
> 
> [External]
> 
> On Thu, 20 Oct 2022 12:02:54 +0300
> Cosmin Tanislav <demonsingur@...il.com> wrote:
> 
> > From: Cosmin Tanislav <cosmin.tanislav@...log.com>
> >
> > regmap_bulk_write() does not guarantee implicit DMA-safety,
> > even though the current implementation duplicates the given
> > buffer. Do not rely on it.
> >
> > Fixes: f110f3188e56 ("iio: temperature: Add support for LTC2983")
> > Signed-off-by: Cosmin Tanislav <cosmin.tanislav@...log.com>
> LGTM.
> 
> As you right observed this is only sort of a fix because right now we
> are fine anyway, so in the interests of getting the rest of the series
> upstream quicker I'll take this one for the next merge window along
> with the rest of the set.
> 
> Thanks,
> 
> Jonathan
> 

Not sure if you already applied this... Anyways:

Reviewed-by: Nuno Sá <nuno.sa@...log.com>