linux-kernel - Re: [PATCH 2/4] staging: r8188eu: remove unnecessary variable in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1YyK7YYshq1nayg@kadam>
Date:   Mon, 24 Oct 2022 09:35:23 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Kang Minchul <tegongkang@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Pavel Skripkin <paskripkin@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] staging: r8188eu: remove unnecessary variable in
 rtw_recv

On Mon, Oct 24, 2022 at 05:05:30AM +0900, Kang Minchul wrote:
> Return _SUCCESS directly instead of storing it in a variable.
> This can prevent cocci warning as follows:
> 
>   Unneeded variable: "ret". Return "_SUCCESS" on line 1516
> 
> Signed-off-by: Kang Minchul <tegongkang@...il.com>

Make the function void instead.

regards,
dan carpenter