linux-kernel - Re: [PATCH v2] perf test: Do not fail Intel-PT misc test w/o libpython

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y1Z5h/Sy6s8AFp1P@kernel.org>
Date:   Mon, 24 Oct 2022 08:39:51 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Namhyung Kim <namhyung@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-perf-users@...r.kernel.org, Ammy Yi <ammy.yi@...el.com>
Subject: Re: [PATCH v2] perf test: Do not fail Intel-PT misc test w/o
 libpython

Em Fri, Oct 21, 2022 at 03:00:04PM -0700, Ian Rogers escreveu:
> On Fri, Oct 21, 2022 at 11:11 AM Namhyung Kim <namhyung@...nel.org> wrote:
> >
> > The virtuall LBR test uses a python script to check the max size of
> 
> nit: virtual

Thanks, fixed and applied.

- Arnaldo
 
> > branch stack in the Intel-PT generated LBR.  But it didn't check whether
> > python scripting is available (as it's optional).
> >
> > Let's skip the test if the python support is not available.
> >
> > Fixes: f77811a0f625 ("perf test: test_intel_pt.sh: Add 9 tests")
> > Cc: Ammy Yi <ammy.yi@...el.com>
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> 
> Acked-by: Ian Rogers <irogers@...gle.com>
> 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/tests/shell/test_intel_pt.sh | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/tools/perf/tests/shell/test_intel_pt.sh b/tools/perf/tests/shell/test_intel_pt.sh
> > index 4c0aabbe33bd..f5ed7b1af419 100755
> > --- a/tools/perf/tests/shell/test_intel_pt.sh
> > +++ b/tools/perf/tests/shell/test_intel_pt.sh
> > @@ -526,6 +526,12 @@ test_kernel_trace()
> >  test_virtual_lbr()
> >  {
> >         echo "--- Test virtual LBR ---"
> > +       # Check if python script is supported
> > +       libpython=$(perf version --build-options | grep python | grep -cv OFF)
> > +       if [ "${libpython}" != "1" ] ; then
> > +               echo "SKIP: python scripting is not supported"
> > +               return 2
> > +       fi
> >
> >         # Python script to determine the maximum size of branch stacks
> >         cat << "_end_of_file_" > "${maxbrstack}"
> > --
> > 2.38.0.135.g90850a2211-goog
> >

-- 

- Arnaldo