linux-kernel - Re: [PATCH] rtc: rtc-cmos: Fix wake alarm breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <836b1787426d5b1569f6d77007a4765ee17d5ea6.camel@linux.intel.com>
Date:   Tue, 25 Oct 2022 08:28:39 -0700
From:   Todd Brandt <todd.e.brandt@...ux.intel.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Mario Limonciello <mario.limonciello@....com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Zhang Rui <rui.zhang@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Linux ACPI <linux-acpi@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org
Subject: Re: [PATCH] rtc: rtc-cmos: Fix wake alarm breakage

On Tue, 2022-10-18 at 18:38 +0200, Alexandre Belloni wrote:
> On Tue, 18 Oct 2022 18:09:31 +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > 
> > Commit 4919d3eb2ec0 ("rtc: cmos: Fix event handler registration
> > ordering issue") overlooked the fact that cmos_do_probe() depended
> > on the preparations carried out by cmos_wake_setup() and the wake
> > alarm stopped working after the ordering of them had been changed.
> > 
> > [...]
> 
> Applied, thanks!

I did testing yesterday on the 6.1.0-rc2 build and this patch hasn't
made it into rc2. This is an extreme inconvenience to anyone testing
low power modes as the rtc wakealarm doesn't function. I'm a little
surprised more people haven't complained.

Please get this in 6.1.0-rc3.

> [1/1] rtc: rtc-cmos: Fix wake alarm breakage
>       commit: 0782b66ed2fbb035dda76111df0954515e417b24
> 
> Best regards,
>