lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Oct 2022 01:59:52 +0700 From: Ammar Faizi <ammarfaizi2@...weeb.org> To: Dave Hansen <dave.hansen@...ux.intel.com> Cc: Thomas Gleixner <tglx@...utronix.de>, Peter Zijlstra <peterz@...radead.org>, Dan Carpenter <dan.carpenter@...cle.com>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>, Josh Poimboeuf <jpoimboe@...nel.org>, Alexei Starovoitov <ast@...nel.org>, Song Liu <song@...nel.org>, Nadav Amit <namit@...are.com>, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] x86/retpoline: Fix crash printing warning On 10/25/22 10:32 PM, Dan Carpenter wrote: > The first argument of WARN() is a condition, so this will use "addr" > as the format string and possibly crash. > > Fixes: 3b6c1747da48 ("x86/retpoline: Add SKL retthunk retpolines") > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> Hello x86 maintainers, I found this patch in the tip tree with the following commit message: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/core&id=98dcf58159365d753b54d07f85a89d61ee15e036 x86/retpoline: Fix crash printing warningx86/core The first argument of WARN() is a condition, so this will use "addr" as the format string and possibly crash. Fixes: 3b6c1747da48 ("x86/retpoline: Add SKL retthunk retpolines") Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com> Link: https://lkml.kernel.org/r/Y1gBoUZrRK5N/lCB@kili When I visited that lkml link, it shows "message ID not found". The problem seems to be coming from the tool used to pick up the patch. That message ID contains a URL special char '/'. Thus it should be URL-encoded like this: https://lore.kernel.org/r/Y1gBoUZrRK5N%2FlCB%40kili Anyway, lkml.kernel.org doesn't work for such a message ID, even with URL-encoded message ID like this: https://lkml.kernel.org/r/Y1gBoUZrRK5N%2FlCB%40kili (not found) -- Ammar Faizi
Powered by blists - more mailing lists