linux-kernel - Re: [PATCH] PCI/PM: Remove unused 'state' parameter to pci_legacy_suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Oct 2022 21:44:10 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     linux-pci@...r.kernel.org,
        Krzysztof Wilczyński <kw@...ux.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] PCI/PM: Remove unused 'state' parameter to pci_legacy_suspend_late()

On Tue, Oct 25, 2022 at 9:35 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@...gle.com>
>
> 1a1daf097e21 ("PCI/PM: Remove unused pci_driver.suspend_late() hook")
> removed the legacy .suspend_late() hook, which was the only user of the
> "state" parameter to pci_legacy_suspend_late(), but it neglected to remove
> the parameter.
>
> Remove the unused "state" parameter to pci_legacy_suspend_late().
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

> ---
>  drivers/pci/pci-driver.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> index 107d77f3c846..a2ceeacc33eb 100644
> --- a/drivers/pci/pci-driver.c
> +++ b/drivers/pci/pci-driver.c
> @@ -646,7 +646,7 @@ static int pci_legacy_suspend(struct device *dev, pm_message_t state)
>         return 0;
>  }
>
> -static int pci_legacy_suspend_late(struct device *dev, pm_message_t state)
> +static int pci_legacy_suspend_late(struct device *dev)
>  {
>         struct pci_dev *pci_dev = to_pci_dev(dev);
>
> @@ -848,7 +848,7 @@ static int pci_pm_suspend_noirq(struct device *dev)
>                 return 0;
>
>         if (pci_has_legacy_pm_support(pci_dev))
> -               return pci_legacy_suspend_late(dev, PMSG_SUSPEND);
> +               return pci_legacy_suspend_late(dev);
>
>         if (!pm) {
>                 pci_save_state(pci_dev);
> @@ -1060,7 +1060,7 @@ static int pci_pm_freeze_noirq(struct device *dev)
>         const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;
>
>         if (pci_has_legacy_pm_support(pci_dev))
> -               return pci_legacy_suspend_late(dev, PMSG_FREEZE);
> +               return pci_legacy_suspend_late(dev);
>
>         if (pm && pm->freeze_noirq) {
>                 int error;
> @@ -1179,7 +1179,7 @@ static int pci_pm_poweroff_noirq(struct device *dev)
>                 return 0;
>
>         if (pci_has_legacy_pm_support(pci_dev))
> -               return pci_legacy_suspend_late(dev, PMSG_HIBERNATE);
> +               return pci_legacy_suspend_late(dev);
>
>         if (!pm) {
>                 pci_fixup_device(pci_fixup_suspend_late, pci_dev);
> --
> 2.25.1
>